-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check notification service before enable #43
base: master
Are you sure you want to change the base?
check notification service before enable #43
Conversation
@FlowBreeze thanks for the PR :) you need to install Let me know if you need a hand with this. Happy to help |
@MichaelAquilina I'm Sorry, I never use circleci before so I just rewrite my code and add |
auto-notify.plugin.zsh
Outdated
# Check dbus-send command exists | ||
if ! type dbus-send > /dev/null; then | ||
# step to default behaviour if dbus-send not exits | ||
print "yes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldnt this be no 🤔 ?
@MichaelAquilina here is my consideration:
And It's ok to change my code as you like |
fac4435
to
92d6926
Compare
fix issue: #42